[CS2113-F11-1] FITNUS #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian030601
added a commit
to Brian030601/tp
that referenced
this pull request
Oct 19, 2023
Connect Calendar with Duke
Meal Logging
Add ExerciseLog class
Implement ExerciseLog into Duke
Fix checkstyle errors
Enable assertions in build.gradle
Add comments to ExerciseLog and associated classes
fix meal
Fix errors
Allow users to update exercises within the exercise log
itayrefaely
reviewed
Nov 1, 2023
There was a problem hiding this comment.
- First, it feels like there are text blocks in the DG which are maybe too long, not organized in bullet points, and are not very technical. Is it possible that this makes it more difficult to understand?
- The DG is missing a few key components, such as target user profile, value proposition, and more.
-
The user stories for versions v1.0 and v2.0 are not related to what appears in the rest of the DG.
-
It seems that the approach you took to make a command superclass is very well explained in the DG, including the logic/reasoning, and also it's implementation structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.